Add glstate.dither.enable() to StateMapping #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (gstate.isDitherEnabled()) { | ||
| glstate.dither.enable(); | ||
| glstate.dither.set(GL_TRUE); | ||
| } |
There was a problem hiding this comment.
Does this need an else that disable()s the dither? I don't really know.
-[Unknown]
There was a problem hiding this comment.
i think may be add it and inline with stencil/depth etc
|
I'm not sure there's really much reason to respect the dither setting if we are running at RGBA8888, as it's mostly used to hide how terrible RGB565 is. But okay :) |
hrydgard
added a commit
that referenced
this pull request
Mar 26, 2013
Add glstate.dither.enable() to StateMapping
|
@hrydgard , in Android/iOS build , i think we are compulsory set colordepth to RGBA8888 .I'm wondering if allow the game to select colordepth like windows build which is TrueColor = false . Would it be faster in Android/iOS build ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.