Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Discord integration for Mac and Linux. #11307

Merged
merged 2 commits into from
Aug 27, 2018
Merged

Conversation

hrydgard
Copy link
Owner

Fixes part of #11303

@hrydgard hrydgard added this to the v1.7.0 milestone Aug 18, 2018
@unknownbrackets
Copy link
Collaborator

gcc: error trying to exec 'cc1obj': execvp: No such file or directory

That's odd. Maybe per StackOverflow this is some Travis issue?

For Mac:

/Users/travis/build/hrydgard/ppsspp/ext/discord-rpc/src/discord_register_osx.m:4:9: fatal error: 'AppKit/AppKit.h' file not found #import <AppKit/AppKit.h>

Maybe we're missing a framework?

-[Unknown]

@ExperiBass
Copy link
Contributor

ExperiBass commented Aug 21, 2018

theres an apple downloads page, maybe this would help? https://developer.apple.com/download/more/?name=
I see the appkit thing, and that made me think of this page.

@unknownbrackets
Copy link
Collaborator

Actually, the issue is that we're using it on iOS for the AppKit thing - doesn't look like discord-rpc is compatible with iOS.

The Linux error is because it's trying to compile the Objective-C file:

gcc: error trying to exec 'cc1obj': execvp: No such file or directory
make[2]: *** [ext/discord-rpc-build/CMakeFiles/discord-rpc.dir/__/discord-rpc/src/discord_register_osx.m.o] Error 1
make[2]: *** Waiting for unfinished jobs....

So it seems like we just need to exclude the osx file on Linux and iOS?

-[Unknown]

@hrydgard
Copy link
Owner Author

Oh, oops. Should be pretty easy to fix both issues, will do soon

(no machines around right now)
@hrydgard
Copy link
Owner Author

Surprise, it built! I'll merge tomorrow when all the buildbot lights should be green.

@ExperiBass
Copy link
Contributor

The lights are green! XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants