Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Update deps; Cannot reproduce #11420 #11426

Merged
merged 1 commit into from
Sep 29, 2018

Conversation

Florin9doi
Copy link
Contributor

@Florin9doi Florin9doi commented Sep 27, 2018

Cannot reproduce #11420
The only problem is that the build process took way too much time.
Is it really required to build every file for 4 architectures multiplied with 2 flavors multiplied with 3 buildTypes ?

@hrydgard
Copy link
Owner

I'm gonna try it with these changes later and see if it still repros for me, maybe also updating the build tools helps.

Yeah well, if you find a way to get the configurations down, let me know. But if you plug in a device and press Run, it will only build a single configuration (first time it will run all the 24 "configures" though).

@Florin9doi
Copy link
Contributor Author

Updating build tools is also required: https://developer.android.com/studio/releases/gradle-plugin#3-2-0

@hrydgard
Copy link
Owner

Don't know what I'm doing wrong but with this branch I'm getting the same thing that I saw before, which is that the output is the following:

Configure project :android
Overriding Android Version Name, Code: 1.6.3-501-Florin9doi-ANDROID_DEPS 16030501
C:\dev\ppsspp\assets

CONFIGURE SUCCESSFUL in 1s

And then it just says Gradle Sync Failed.

All I see in idea.log is:

2018-09-29 00:23:28,743 [d thread 1]   INFO - e.project.sync.GradleSyncState - Gradle sync failed (2 s 434 ms) 

@hrydgard
Copy link
Owner

I did upgrade Android Studio to 3.2, maybe related...

@unknownbrackets
Copy link
Collaborator

Working here. Android Studio 3.2, ndk r18, had to update sdk for 28.0.3. Appears successful.

-[Unknown]

@hrydgard
Copy link
Owner

Alright. I'm just gonna merge this and troubleshoot my environment then...

@hrydgard hrydgard merged commit 2e8e28f into hrydgard:master Sep 29, 2018
@hrydgard
Copy link
Owner

Strangely, I can build and run (gradle assemble works) but sync (from the IDE) just insta-fails, so it builds all configurations even though it doens't have to. Very odd...

@unknownbrackets unknownbrackets added this to the v1.7.0 milestone Oct 4, 2018
@Florin9doi Florin9doi deleted the ANDROID_DEPS branch October 7, 2018 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants