Replay: Add file header handling and ignore PSP/GAME reads #12153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless there are writes in this directory, we should be able to safely ignore them. Currently detection isn't perfect (like PSP/./GAME/../GAME), but this should catch the vast majority of cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly, this adds some basic header handling to #10888, so that it can include the base time. I left some reserved slots in case we decide to make other random state less deterministic between runs without breaking BC reads of replay files.
I'm thinking of trying to create a plugin to record PSP control inputs (would ignore IO to focus on rhythm stuff) as noted in #12092. It could just use this same format and replay framework in PPSSPP. The biggest challenge to that will be loading screen timing, but maybe a value in PSP RAM can be found that indicates "in game" to align timing...
Also adds some code to best-effort address the concern brought up in #12104 of recording DLC data in replays (obviously commercial games, in general, would either be UMDs or mounted PBPs, and not go through DirectoryFileSystem.)
-[Unknown]