Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Initial basic replay recording #10888

Merged
merged 5 commits into from Apr 8, 2018
Merged

Conversation

unknownbrackets
Copy link
Collaborator

This is not about TAS, I'm not a TAS person. For me it's more about rewind and issue repro (even locally, when some game misbehaves and a state would cement bugs.)

This doesn't have any UI or file format handling yet, and there's no integration with rewind yet either.

-[Unknown]

@hrydgard
Copy link
Owner

hrydgard commented Apr 8, 2018

This is very cool. Took me sec to understand what all the file stuff is about, but it's for replay playbacks to function even when games were reading from disc during the recording by storing the data that was read.

@hrydgard hrydgard merged commit 6fccefa into hrydgard:master Apr 8, 2018
@unknownbrackets unknownbrackets deleted the replay branch April 8, 2018 13:57
@unknownbrackets
Copy link
Collaborator Author

Yeah, otherwise you get in a weird place with games that do autosaves or etc. - you can't replay the same data. This way should make it transparent to the game that the save data has changed.

Haven't totally figured out UI at this point.

For rewind, I'm thinking it can at least take snapshots less often (it will cause "scrubbing" to do this though.)

I've also realized that rewind is processed at the beginning of a frame (rather than end.) I've been considering tying it into timing because sometimes we have less expensive frames and I'd rather take the rewind snapshot then if possible.

-[Unknown]

unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this pull request May 6, 2018
Replay (hrydgard#10888) caused error to be non zero, which was later translated to
something else, confusingly...
@unknownbrackets
Copy link
Collaborator Author

Just a note: because of #11019 this will probably be reverted. I'm not interested enough in this functionality to chase some obscure virus scanner or whatever might be causing the issue, so this will probably be abandoned.

-[Unknown]

@hrydgard
Copy link
Owner

Actually I'm not sure I want to revert... If it's that hard to reproduce, and in a game that already doesn't work very well, I say meh, let's keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants