Add debugger APIs for replay recording #14493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks simple and unintrusive. nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes APIs to record and re-execute replay data.
A simple example is to send
replay.begin, wait for a while (possibly listening for a certain keypress), and then sendreplay.flushto save the data. Then usereplay.executeat the start. Also allows you to save/restore the RTC time.In theory this can be used for TAS (and ties events to exact internal clock times), but as noted in #10888 I'm not necessarily pursuing TAS. This is useful for debugging and automated functional testing.
There's no integration with rewind or save states still.
Also, this fixes reading larger data packets - surprised I missed that. Might fix memory API issues for some if writing large chunks.
-[Unknown]