TexCache: Fix 16->32 colors with CLUT start pos #16358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't need larger than 2 KB CLUT buffers, since it's actually only 1 KB. We have a hack that allows 2 KB for separate mip map levels.
5 tasks
Owner
|
Ooh, nice catch! |
|
This is also fixes #16335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting a texture from 16-bit to 32-bit (i.e. to save textures or for a GPU that lacks 16-bit texture support), we were expanding the CLUT to a buffer, and then using that directly, for efficiency.
This expansion failed to consider the start pos, so had uninitialized values or previous CLUT values in it. Additionally, the buffer was not large enough for large start pos values, which could cause invalid accesses or other bad things.
This expands the buffer, aligns it (so color conv uses SIMD - it was usually at +4 before), and expands the portion of it pointed to by the start index (and shift.)
Fixes #16331, fixes #12188 (finally - must've been a device without 16-bit format support.)
-[Unknown]