TexCache: Cleanup BGRA flag dirtying #16366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
added
the
Code Cleanup
|
Try this build from artifacts and confirm is fixed wrong color rendering on all backends, except Vulkan is crash immediately (in menu game) after enable save new textures option. |
|
Hm, I'll look at that Vulkan crash separately. It doesn't look like it's likely related to this PR. |
|
nervermind, I put PPSSPP in a new folder and try again, it not crash anymore. thank! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at #16331, and not finding any cause for a BGRA swap, I figured this flag should dirty the same way as the others.
-[Unknown]