Retroachievements support (work-in-progress)

[hrydgard]

Implement RetroAchievements support (#16169). Not to be confused with RetroArch, these are two different projects.

Most of RetroAchievements.cpp was adapted from DuckStation's integration by @stenzek.

So far, login works (unless you're on a touchscreen device), game identification and basic achievement listing works, and unlocking achivements works.

TODO list before initial merge:

• Login UI, basic settings
• Proper achievement listing UI from the pause screen
• On-screen notification UI for unlocks
• Fix the game hashing so it can work with scoped storage
• More secure login token storage
• Fill in the remaining translation strings in en_US.ini (will add actual translations in the next PR)

Next steps after this:

• Leaderboards UI
• HTTPS support (we force HTTP because our client implemenetation lacks ssl support)
• Challenge mode (disable savestates etc)
• Juicy sound effect for unlocks
• Other missing features

[cannnAvar]

How we can use achivements now

[hrydgard]

Stay tuned, it's not ready enough yet.

[hrydgard]

Rebased on top of #17594 .

[stenzek]

Got pinged about this, please maintain my copyright notice in DuckStation-derived files (and add your own, obviously), thanks.

Also, feel free to relicense those files to GPL2 to match the rest of the emu if that makes things easier (in DS it's GPL3).

[hrydgard]

@stenzek will do, thank you!

[hrydgard]

Progress report: You can now login through the UI, and play and get achievements, and you do get nice little popups with achievement icons and text when you do. There is also an achievement list on the pause screen, if achievements are enabled for the game. Logging in works on all desktop platforms currently - or if you have a physical keyboard for your phone somehow. This will of course be fixed soon.

I'll do a more general fix for text input UIs on master soon, then bring it into this PR.

EDIT: Confirmed working fine on Android except a weird centering issue, the code updates are coming soon.

[hrydgard]

This is starting to get usable now, opening for review, but don't merge until the below is solved:

I think we should probably store the RetroAchievements login token somewhere slightly more secure than in PPSSPP.ini, it's too easy to accidentally leak your token while sending that file in for debugging or something.

On Android we'll just store it in a file in the app private directory.

On Windows, Mac, Linux, I'm thinking just store it in a separate file in the home directory somewhere?

[Captainquill]

Hello sir.. When will this be ready to download. Just a tentative release Window.?

[hrydgard]

Next week it will be in the "nightly" builds.

[anr2me]

Hello sir.. When will this be ready to download. Just a tentative release Window.?

Currently you can also download the artifacts from https://github.com/hrydgard/ppsspp/actions/runs/5360144898?pr=17589 if you want to test it.

[hrydgard]

Should be ready for initial review/merge now.

[hrydgard]

Hm, actually need to clean up the choice of directory for secrets storage. It's not making good choices on some platforms.

[hrydgard]

Ok, I've been thinking about where to put the login token on various platforms. One idea would be the following:

• Android: It clearly belongs in the app private data folder.
• Windows: There are two cases here:
  • installed: %APPDATA%\PPSSPP ?
  • portable: memstick/PSP/SYSTEM , next to the ini (but not included in the ini file)
• Linux/Mac: memstick/PSP/SYSTEM
• iOS: ?
• Switch: ?

However, after some chats I think I might be overthinking it. It's only really important to keep it out of the .ini as we often ask people to post that. But just putting the login token in a file next to the ini on all platforms may be good enough, really.

[hrydgard]

Alright, I think this is a pretty good checkpoint, and I'm just gonna get it in and work from that state.

[unknownbrackets]

Not sure what this is for specifically, but it should be using lock_ in case someone starts calling it later.

-[Unknown]

[hrydgard]

I never used it for anything, I'll just delete it. Was gonna be used to test achievement popups without getting achievements.