UI: Icon image cache #17599
Merged
UI: Icon image cache #17599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be needed for achievements, and has uses already now.
It doesn't try to insert or fetch missing things itself, re-fetching is up to the caller. This will be required for handling the many achievement icons. Saving/loading the cache to a single file on disk is implemented but not hooked up yet. It works without it, though of course will have to re-fetch things on the next startup.
…g used. They can be recreated pretty quickly as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple small-image cache.
It can be stored to disk (single file, for performance on Android) and restored. Though this is not yet hooked up, and I'm not sure we want it.
Will be needed to manage all the little achievement icons for #17589 . No need to cache them on disk, but something has to own them.
This also uses the icon cache for the icons in the homebrew store, for testing the concept.