Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Simplify GetShaders and DirtyLastShader, making them internally consistent. #18218

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Sep 24, 2023

There was some weirdness before where the cached pointers and IDs could potentially get out of sync...

This was caused by the difference of DirtyShader and DirtyLastShader which didn't make all that much sense to have as two different functions.

This also reduces the number of shader hash lookups in some circumstances.

@hrydgard hrydgard added this to the v1.16.4 milestone Sep 24, 2023
@hrydgard hrydgard merged commit acf530e into master Sep 24, 2023
18 checks passed
@hrydgard hrydgard deleted the simplify-getshaders branch September 24, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant