Startup and tex-replacement performance fixes #18296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // (this is an external process.) | ||
| bool result = VulkanMayBeAvailable(); | ||
|
|
||
| LogManager::Shutdown(); |
There was a problem hiding this comment.
Hm, not even starting up the log manager. Might be safer not to call these things in case they start crashing in certain cases later when init never happened.
-[Unknown]
There was a problem hiding this comment.
hm, yeah, I got a little aggressive here - wanted the spawned process to be as pure a VK check as possible, and missed this path. I'll clean it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vulkan-in-other-process check was slower than necessary by using shell APIs early in startup, which cost a couple hundred ms to load. Let's avoid that.
I found this while profiling for another problem, which was that texture replacement decimation tries to lock textures, and we ended up blocking the main thread unnecessarily while large textures were loaded, leading to less performance glitches when using texture packs.