Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize DrawPixels for 16-bit RGB565 copies #18416

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Nov 12, 2023

These are done repeatedly in God of War, and are slightly expensive on platforms like RISC-V due to unnecessary color conversion (we don't have optimized color conv functions for RISC-V yet).

So let's just use a 16-bit texture format directly if available instead of converting (and if the opposite RGB16 format is available, use that since conversion is cheap even without SIMD).

@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Nov 12, 2023
@hrydgard hrydgard added this to the v1.17.0 milestone Nov 12, 2023
…propriate.

Optimization for God of War on low-end platforms. Avoids calling a color
conversion function that's currently only SIMD-optimized on x86, so will
also benefit ARM a little bit.
@hrydgard hrydgard merged commit bfd1115 into master Nov 12, 2023
18 checks passed
@hrydgard hrydgard deleted the drawpixels-16-bit-opt branch November 12, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant