Enforce run-behind-pause-screen if ad-hoc multiplayer active #18647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
Networking / adhoc
User Interface
anr2me
reviewed
Dec 30, 2023
Core/HLE/sceNetAdhoc.cpp
Outdated
| @@ -126,6 +126,9 @@ static int sceNetAdhocPdpCreate(const char* mac, int port, int bufferSize, u32 f | |||
| static int sceNetAdhocPdpSend(int id, const char* mac, u32 port, void* data, int len, int timeout, int flag); | |||
| static int sceNetAdhocPdpRecv(int id, void* addr, void* port, void* buf, void* dataLength, u32 timeout, int flag); | |||
|
|
|||
| bool __NetAdhocConnected() { | |||
| return netAdhocInited && netAdhocctlInited && adhocctlState == ADHOCCTL_STATE_CONNECTED; | |||
There was a problem hiding this comment.
it should be (adhocctlState == ADHOCCTL_STATE_CONNECTED || adhocctlState == ADHOCCTL_STATE_GAMEMODE) as gamemode is also in connected state, similar to
ppsspp/Core/HLE/sceNetAdhoc.cpp
Lines 2285 to 2287 in d2ebd36
There was a problem hiding this comment.
Fixed it up, please test :)
There was a problem hiding this comment.
I only tested this on 2 games, Naruto Shippuden Ultimate Ninja Heroes 3 (normal adhoc), and Bomberman (gamemode), seems to be okay.
There was a problem hiding this comment.
Thanks for testing! I think it should be generally fine, I guess we'll get bug reports if it isn't.
hrydgard
force-pushed
the
enforce-runbehind-multiplayer
branch
from
69948bf
to
23a253d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces the game to keep running behind the menu if adhoc is connected, avoiding desyncs-by-mistake.
@anr2me What do you think? Is this the right approach?