Fix "Savestate Slot" string #18891
Merged
Fix "Savestate Slot" string #18891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
reviewed
Feb 25, 2024
UI/NativeApp.cpp
Outdated
| @@ -1200,7 +1200,7 @@ bool HandleGlobalMessage(UIMessage message, const std::string &value) { | |||
| return true; | |||
| } else if (message == UIMessage::SAVESTATE_DISPLAY_SLOT) { | |||
| auto sy = GetI18NCategory(I18NCat::SYSTEM); | |||
| std::string msg = StringFromFormat("%s: %d", sy->T("Savestate Slot"), SaveState::GetCurrentSlot() + 1); | |||
| std::string msg = StringFromFormat("%s: %d", std::string(sy->T("Savestate Slot")), SaveState::GetCurrentSlot() + 1); | |||
There was a problem hiding this comment.
Good catch, but that's not gonna work, can't pass an std::string as a format parameter.
Either use T_cstr() which remains for this use, or .c_str() after constructing the std::string.
There was a problem hiding this comment.
Well, it's only for ("Savestate Slot") part and works as such, but ok, I'll change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how long it was broken nor if there are any similar to fix, very minor thing that nobody notices.