Fix an oversight where sound would never be initialised if a game is started with it off, and then is enabled later. #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with it off, then later enabled.
|
This bug has been for long time and good to see if get fixed :) |
|
Yeah, it was simple to fix. 👍 Someone just forgot to initialise sound if it's enabled at a later point. No big deal. |
hrydgard
added a commit
that referenced
this pull request
Aug 14, 2013
Fix an oversight where sound would never be initialised if a game is started with it off, and then is enabled later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if a user started a game with sound disabled, the mixer would never be initialised, even if they turn it on later, and they're still in-game. This simply checks to see if mixer isn't null(and that we're in-game via PSP_IsInited) and if it is, it initialises it.
It was just an oversight, really.