Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use glBlendFuncB for dstAlpha #3460

Merged
merged 1 commit into from
Aug 31, 2013
Merged

Use glBlendFuncB for dstAlpha #3460

merged 1 commit into from
Aug 31, 2013

Conversation

raven02
Copy link
Contributor

@raven02 raven02 commented Aug 28, 2013

This negate the blue effect on 3rd birthday while maintains Person 2 blend fix.

Issue #3354

@thedax
Copy link
Collaborator

thedax commented Aug 28, 2013

Seems fine with Tactics Ogre, Pangya, and Half-Minute Hero, so no objections here.

@hrydgard
Copy link
Owner

Hm, I thought I tested this before, but I can't remember what problem it caused..

@thedax
Copy link
Collaborator

thedax commented Aug 28, 2013

Probably a good idea to hold on merging this until @solarmystic runs through his usual tests.

@solarmystic
Copy link
Contributor

@raven02 @thedax @hrydgard

Test report for your perusal (just had to alter the line as per the commit, pretty simple alteration):-

capture

Observations of note:-

  1. Final Fantasy 2's graphical regressions did not spawn from this commit. The issue is also present in the current master and is the return of a previous issue, Final Fantasy II (ULES00987) :- Minor graphical abnormality in status menuboxes since v0.8.1-634-g1abd9ff (Updated, issue has since returned in v0.9.1-222-g711d3ff)  #2857 (comment) due to a different responsible commit.
  2. 3rd Birthday's thick blue fog (with just plain BR) has indeed been resolved with the alteration, but you can still see that it's not quite right yet in this screenshot. Note the tiny blue rectangular artifacts, and the blue "aura" around Aya's body. These are obviously not present with BR is turned off.

Still a massive improvement to what it was before anyway, and since it does not negatively affect any other games I have tested, it should be safe enough to merge.

3rdbdaymostlyfixed

@raven02
Copy link
Contributor Author

raven02 commented Aug 29, 2013

@solarmystic Thanks for testing .

@hrydgard
Copy link
Owner

Alright then, let's try it.

hrydgard added a commit that referenced this pull request Aug 31, 2013
Use glBlendFuncB for dstAlpha
@hrydgard hrydgard merged commit 7e96e2c into hrydgard:master Aug 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants