Write 0 to outposAddr when before return ATRAC_ERROR_ALL_DATA_DECODED #4837
Conversation
…eturn ATRAC_ERROR_ALL_DATA_DECODED
| // Just loop the whole audio | ||
| atrac->loopStartSample = 0; | ||
| atrac->loopEndSample = atrac->endSample; | ||
| } else { |
There was a problem hiding this comment.
There's no changes here except putting it into an else, right? Just indents the code more, doesn't it? Is there another reason for this change?
-[Unknown]
There was a problem hiding this comment.
Yep , just indents the code and put else only .No functional changes.
There was a problem hiding this comment.
It'd be nice if you didn't so much. It really makes the git history a lot harder and more annoying to follow, and I really don't see how more indented is better anyway. Changing it again would be even worse, of course.
-[Unknown]
|
This needs tests, but still looks reasonable enough that I'm fine with merging, as it makes sense and fixes a game. |
Write 0 to outposAddr when before return ATRAC_ERROR_ALL_DATA_DECODED
|
This breaks frontier gate boost+,nonstop loading on loading game save or starting new game after video. |
|
Maybe open new issue for frontier gate boost+ ? |
This fixes #4382
Thanks @sum2012 to find out the issue.