Optimize framebuffer binding and blits #6800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just in case, since it overrides the texture.
If we're just going to bind another one, no need to trade around.
Might be needed if the list is stalled, a copy is done, list unstalled, and then something happens to flush a pending prim.
As far as I can tell, this doesn't need a temp fbo.
hrydgard
added a commit
that referenced
this pull request
Aug 28, 2014
Optimize framebuffer binding and blits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one area of Tales of Phantasia X, there is a hot town where there are a ton of intra-buffer blits done in a row each frame. This town only ran at 95% for me at best on desktop.
Avoiding the temporary fbo in an intra-buffer blit helped a lot, bringing it up to 150%. With the other optimizations (avoiding unbinding and fbo caching), it's now up to 190%.
This is of course an extreme case. Another example, Trails in the Sky, seemed to benefit only about 1% from these changes in certain cases, and probably less most of the time.
Requires hrydgard/native#234.
-[Unknown]