Video: Enable threads for video decoding #9484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously getting (accidentally?) enabled by the call to `avformat_find_stream_info()`. See hrydgard#9262.
|
Wait, so setting "threads" to "0" helped? That seems like the opposite of what you'd want... Oh, no, I'm wrong. "0" means "optimal" while "1" would have forced it to be single-threaded. |
|
And yeah, it might make sense to set this for the other ways we use ffmpeg too... |
|
I tried it for atrac, it doesn't seem like it uses any threads anyway. -[Unknown] |
|
Alright, well, we could do atrac on a thread on our own, similarly to sceSas I suppose, though not sure it's worth the trouble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narrowing it down to #8867 really helped. This was previously getting (accidentally?) enabled by the call to
avformat_find_stream_info(). We skip that now, so threads seem to be disabled. It's definitely using threads before that change.Weirdly, all that function seems to do related to threads is to disable them for a separate, temporary codec used to detect things about the streams. Maybe there's some global state that's changed.
See #9262 - this fixes it for me, but want to let @zminhquanz confirm.
Also worth noting: we only call
avformat_find_stream_info()here. I'm not sure if Atrac/PMP/recording/etc. might benefit from a similar change.-[Unknown]