🚀 [shape] add <Area /> and tests
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[shape][area] more proptypes [shape][area][tests] fix test
williaster
commented
Oct 31, 2017
| @@ -67,6 +67,15 @@ Object.defineProperty(exports, 'LinkRadial', { | |||
| } | |||
| }); | |||
|
|
|||
| var _Area = require('./shapes/Area'); | |||
There was a problem hiding this comment.
not sure how the build file got in, but looks like it's been there for a while. let me know if you want me to remove it here!
hshoff
approved these changes
Oct 31, 2017
| @@ -67,6 +67,15 @@ Object.defineProperty(exports, 'LinkRadial', { | |||
| } | |||
| }); | |||
|
|
|||
| var _Area = require('./shapes/Area'); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This PR adds a new
<Area />component (+ tests) to the@vx/shapepackage to support confidence bands, which the current<AreaClosed />component doesn't support. I left the current<AreaClosed />component in addition to the new component to avoid breaking changes and because I think there's merit having specialized components for this.Tested with jest and functionally / visually with a linked
@data-uilibrary: