[shape] add arc prop undefined checks. fixes #462 #464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 Breaking Changes
<Arc />
and<Pie pieValue={} />
props now check for!== undefined
. Before0
wouldn't set the prop to0
becauseif (0)
isfalse
. This is only a breaking change if you were passing0
before and happy with<Arc />
treating that asundefined
and using d3.arc() defaults.🐛 Bug Fix
<Arc />
now respects0
as an allowed prop value<Pie />
pieValue
now respects0
as an allowed prop value🏠 Internal
<Arc />
testsArc.test
fromCRLF
=>LF