Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(vx-demo): convert Heatmap to codesandbox #676

Merged
merged 4 commits into from
May 21, 2020
Merged

new(vx-demo): convert Heatmap to codesandbox #676

merged 4 commits into from
May 21, 2020

Conversation

williaster
Copy link
Collaborator

📝 Documentation

🏠 Internal

Part of #624, re-writes the Heatmap demo to link out to code-sandbox. Link (update branch to master upon merge).

image

image

@kristw @hshoff

@williaster williaster added this to the v1 milestone May 6, 2020
@williaster williaster mentioned this pull request May 6, 2020
Closed
hshoff
hshoff requested changes May 7, 2020
View reviewed changes
Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep /heatmaps doesn't seem worth adding redirects to support old links

@williaster
Copy link
Collaborator Author

@hshoff this one should be good now, reverted to /heatmaps

@williaster williaster merged commit 23a36a7 into master May 21, 2020
@williaster williaster deleted the chris--sandbox-heatmap branch May 21, 2020 19:39
@hshoff hshoff modified the milestones: v1, v0.0.197 Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

Assignees
No one assigned
Labels
📝 docs 🏠 internal
Projects
None yet
Milestone
v0.0.197
Development

Successfully merging this pull request may close these issues.
2 participants
@williaster @hshoff