new(vx-axis): use numTicks when falling back on scale.domain #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hshoff
approved these changes
Jun 17, 2020
williaster
changed the title
williaster
force-pushed
the
chris--axis-ticks
branch
from
c9e1418
to
1049a1f
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This makes a small update to
@vx/axisfor non-continuous scales. Continuous scales support.ticks([count]), but things like band scales do not.Currently
Axiswill use.ticks()if it exists, and falls back to.domain()for scales that don't have it. This is fine except for charts with a very largedomain, in which case it'd be an improvement to account fornumTicksif it's passed, to allow filtering to a reasonable number without requiring full specification oftickValues. I added that logic here.Before
After
@hshoff @kristw