Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(vx-shape): add SplitLinePath #778

Merged
merged 4 commits into from
Aug 14, 2020
Merged

new(vx-shape): add SplitLinePath #778

merged 4 commits into from
Aug 14, 2020

Conversation

williaster
Copy link
Collaborator

🚀 Enhancements

Digging this one up from over a year ago before I lose the branch:

  • adds a SplitLinePath component to @vx/shape that allows you to create a line path split into multiple smaller line paths that can be styled independently
  • adds a demo example

image
image

@hshoff @kristw

@williaster williaster added this to the 0.0.199 milestone Aug 12, 2020
williaster
williaster commented Aug 12, 2020
View reviewed changes
packages/vx-demo/src/sandboxes/exampleToVxDependencyLookup.ts
bargroupHorizontalPackageJson,
bargroupPackageJson,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 abc

williaster
williaster commented Aug 12, 2020
View reviewed changes
packages/vx-shape/src/shapes/SplitLinePath/getLineSegments.ts Outdated
}
}

export default memoize(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is generally the approach that we use in @vx/text

hshoff
hshoff reviewed Aug 13, 2020
View reviewed changes
Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why shapes/SplitLinePath/index and not shapes/SplitLinePath?

@williaster
Copy link
Collaborator Author

I can refactor it to shapes/SplitLinePath, I created SplitLinePath/ to co-locate the getLineSegments.ts util with the component it's used with. But that's easy to move to util/ which already exists in the package

@williaster
internal(vx-shape/SplitLinePath): remove dir structure, fix types, fe…
6bcd74d 
…wer multiplications, improve path measurement node attributes
@williaster williaster merged commit e6b394d into master Aug 14, 2020
@williaster williaster deleted the chris--splitpath-for-real branch August 14, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

@kristw kristw kristw approved these changes

Assignees
No one assigned
Labels
🚀enhancement 🐯 example
Projects
None yet
Milestone
0.0.199
Development

Successfully merging this pull request may close these issues.
3 participants
@williaster @hshoff @kristw