test: increase code coverage #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hshoff
commented
Aug 19, 2020
| const HOC = withBoundingRects(Component); | ||
| const wrapper = mount(<HOC />); | ||
| const RenderedComponent = wrapper.find(Component); | ||
| expect(RenderedComponent.prop('rect')).toEqual(emptyRect); |
There was a problem hiding this comment.
🤔 wasn't sure how to mock the RenderComponent.node.parentNode to not have getBoundingRect which triggers the parentRect = emptyRect branch... so skipped it for now. Safe to assume it works.
williaster
approved these changes
Aug 19, 2020
| @@ -1,54 +0,0 @@ | |||
| import { withBoundingRects } from '../src'; | |||
|
|
|||
| // const expectedRectShape = expect.objectContaining({ | |||
There was a problem hiding this comment.
didn't know this was all commented out 😮
kristw
reviewed
Aug 19, 2020
| @@ -65,4 +65,15 @@ describe('<LinePathAnnotation />', () => { | |||
| ), | |||
| ).toBe(true); | |||
| }); | |||
|
|
|||
| test('it should have default x and y accessors', () => { | |||
There was a problem hiding this comment.
We could use it(...) function instead of test(...) too so it will read more like
it('should have default x and y accessors', ...)There was a problem hiding this comment.
sure, i don't have a preference
kristw
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes vx from 26% to 44% code coverage. More to come in future PRs...
🏠 Internal