Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns same data as the input #1

Closed
ctapobep opened this issue Oct 13, 2018 · 4 comments
Closed

Returns same data as the input #1

ctapobep opened this issue Oct 13, 2018 · 4 comments

Comments

@ctapobep
Copy link

I tried to use the test() method and instead of this:

sig = np.cos(2*np.pi*7*t) + np.sin(3*np.pi*7*t+300*t)

I entered my chromatogram. But in the end the original signal and the result are almost the same. Do I need to tune the params? I don't understand the math behind it yet, so I was hoping that the algorithm would "just work".

Here are these chromatograms in 1 plot (you see only 1 line because they are very similar):
figure_1

And here is plt.plot(domain, sig - x.squeeze(), 'g'):

diff

@ctapobep
Copy link
Author

ctapobep commented Oct 13, 2018

Noticed a cut-off frequency in the code, which depended on the signal length. Changing it to 0.9 did have an effect:
fc09

Though still not satisfactory at the beginning and at the end of the chromatogram. Is this fixable with tuning of other params or these artifacts can't be fixed with BEADS?

@hsiaocy
Copy link
Owner

hsiaocy commented Oct 16, 2018

Hi ctapobep,
Thanks for adopting this algorithm, but I'm regretfully to say that I didn't spend much time on this algorithm. Perhaps you could try different parameters because I tried it originally for comparing against Wavelet Transform and Hilbert-Huang Transform in the electrocardiogram.
That's why I'm so sorry that I cannot explain detail for you.

@ctapobep
Copy link
Author

Ok, got it, thanks. Did you decide in the end to use BEADS instead of other alternatives for baseline correction?

@hsiaocy
Copy link
Owner

hsiaocy commented Oct 16, 2018

Yes, for my research of electrocardiogram pre-processing, I eventually used HHT because it speeds up the whole working flow.
I have no base about chromatogram but just giving you a suggestion.

@hsiaocy hsiaocy closed this as completed Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants