Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Parameter checks #56

Closed
hsloot opened this issue Jun 30, 2020 · 1 comment
Closed

[REVIEW] Parameter checks #56

hsloot opened this issue Jun 30, 2020 · 1 comment
Assignees
@hsloot
Labels
good first issue Good for newcomers help wanted Extra attention is needed review Some code is due for review
Milestone
Release 0.3

Comments

@hsloot
Copy link
Owner

hsloot commented Jun 30, 2020

Proposal

At the moment, most of the parameter checks are implemented in R using assertthat. A consequence of that is a performance hit - in particular, if large parameters are involved. It would be good to either incorporate parameter checks directly in the support library or at least rewrite some of the tests in C++.
@hsloot hsloot added help wanted Extra attention is needed good first issue Good for newcomers review Some code is due for review labels Jun 30, 2020
@hsloot hsloot added this to the Release 0.3 milestone Jun 30, 2020
@hsloot hsloot self-assigned this Jun 30, 2020
@hsloot hsloot mentioned this issue Dec 12, 2020
Closed
@hsloot
Copy link
Owner Author

hsloot commented Dec 12, 2020

now outdated due to #67

@hsloot hsloot closed this as completed Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsloot hsloot

Labels
good first issue Good for newcomers help wanted Extra attention is needed review Some code is due for review
Projects
None yet
Milestone
Release 0.3
Development

No branches or pull requests
1 participant
@hsloot