-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettified shouldBe #24
Conversation
This is awesome! Regarding a better diff solution: I would think that a pretty-printed output like done in this PR combined with a textual diff would go a long way in making test failures more readable. (@sol made an effort to have textual diffs, not sure about the state of that.) |
One thing that I'm worrying about is this: We should be very careful when adding new dependencies to Added (transitive) dependencies for this PR are:
|
@soenkehahn
I haven't found anything good or generic yet, which is unfortunate. I could content myself to a textual diff as long as it was intelligent about including context and was pure Haskell but I haven't found that yet. One of the libraries I found shelled out to |
@bitemyapp: Re dependencies: Yeah, makes sense. Adding more class constraints would indeed be bad. I'd like to know how long it takes to build the additional dependencies. (I'm planning to measure this, if you don't get to it first.) |
@soenkehahn go for it. |
Guys, it would be awesome to have something like this on master. This needs to be rebased, and we still need to measure the build time impact. Anybody wants to help with this? |
I'm not sure why this branch has conflicts with master now. My guess is the Cabal file.
|
Sidebar: |
With a recent change to I implemented @bitemyapp Would you be willing to port this code over to |
Closing in favor of hspec/hspec#294 |
@sol fine by me, thank you. |
Cf. yesodweb/yesod#1259
Why?
Before:
After:
Takes up more space, but is more readable. YMMV.
I'd like to figure out a good (SYB/Generics driven, ideally) diff solution for a future PR, suggestions to this end would be appreciated.