Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning error instead of raising when a transaction is not mined. #31

Closed
aguxez opened this issue Dec 2, 2018 · 0 comments
Closed

Comments

@aguxez
Copy link
Contributor

aguxez commented Dec 2, 2018

At the moment when you try to check the receipt of a transaction tx_receipt/1 with a hash of a transaction which has not been mined yet, the function will raise a BadMapError I think it should be better to return an error ({:error, :not_mined} in this case) so we don't cut operations of related functions outside of the library,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant