Feature request: add an option to allow inline elements inside a span

[jznf]

current behaviour is that:

<span><button>OK</button></span>

throws:

Warning: inserting implicit <span>
Warning: replacing unexpected button with </button>
Warning: missing </button>

and the final result is:

<span><button><span>OK</span></button></span>

It might be handy to have an option to prevent this behaviour and let the original markup unchanged as it is valid and it's a part of quite common pattern.

[geoffmcl]

@jznf, thank you for bringing this here...

As discussed, off list, this has been the behavior of tidy for a long time, thus any change should be subject to a new option, to suspend this action... probably not too difficult...

Very much welcome any thoughts on this... thanks...

[geoffmcl]

As we are about to release 5.4, and there has been no progress on this Feature Request, moving it to next, 5.5 milestone...

I have constructed a sample in_461.html which passes W3C validation, so certainly think this feature should be added, even as the default...

As always further comments, patches or a PR very welcome... thanks...

[lhchavez]

Ah this is just a difference in the HTML5 spec. Previously <button>..</button> was allowed to contain flow as children (which includes blocks and inlines). In HTML 5, that is restricted to phrasing content (only inline elements)

I'll send a PR for this.

[geoffmcl]

@lhchavez as stated. thank you for your PR #531... While this works fine, I have now proposed an alternative fix, PR #540, that not only addresses this <button> issue, but tidies up some other code... including an important fix for the TY_(IsHTML5Mode)(doc ) service...

I have been delaying merging #540 hoping you would get a chance to pull and test the issue-461 branch, and confirm. @balthisar has already tested, and confirmed...

And now there is also a branch issue-461 in the tidy-tests repo, which should match this change, and should pass 100% - stage 1 - exit codes, and 2 - diff results vs expects...

I understand RL must come first, but you say closing your #531, and/or adding a +1 here, or something, would indicate for me to move forward...

I am also holding off on a few other PRs to get #540 in place first... which will bump us to 5.5.15... thanks...

[lhchavez]

oh, sorry i've been in the critical path. please go ahead and merge that other change since it's clearly better for everyone!

if i end up seeing other issues, i'll send further PRs. i'll close this one.

[lhchavez]

(and by "this one" i mean the one i sent)

[geoffmcl]

@lhchavez thanks for the quick reply... sorry to push when there may be other critical RL items...no apology needed...

It's a bit late in my working day today, to get into merges, etc, but will get to it tomorrow, or soonest... thanks...

[balthisar]

Should I merge everything we've both okayed? I'm still GMT-5, so might be able to get to it tonight.

[jznf]

THANK YOU!!!