-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix behavior of <button> elements in HTML 5 #531
Conversation
HTML 5 restricts the children of <button> elements to only phrasing content. HTML 4 also allowed block elements. In particular, this change allows code such as <span><button>OK</button></span> to be left as-is, since the <span> does not need duplication for crossing a block boundary. Mitigates htacg#461.
PTAL! This was tested against geoffmcl/tidy-test@4f6089b and passes. |
As replied to #530... |
Confirmed as working on macOS. |
@lhchavez sorry for the delay on this... I was working on an alternate patch, to put this change of the parser for And have pushed my patch to the This would keep all the But ran into On investigating this, it seems some errors have crept into the Now most of the In other words, this That is we now expect, allow some html5 tolerance in a legacy document, and this is an error! And there seems to be several other similar cases... yet to be explored fully... Now this has nothing to do with |
PS: Now opened Issue 15... Any help appreciated... thanks... |
HTML 5 restricts the children of elements to only phrasing
content. HTML 4 also allowed block elements.
In particular, this change allows code such as
to be left as-is, since the does not need duplication for
crossing a block boundary. Mitigates #461.