Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update domainurl in service.js of mobile app #2

Closed
tonysurma opened this issue Jul 20, 2015 · 3 comments
Closed

update domainurl in service.js of mobile app #2

tonysurma opened this issue Jul 20, 2015 · 3 comments

Comments

@tonysurma
Copy link
Member

For now there is a soon to be - if not already - dead url for domainurl in service.js of the mobile app.

We need to make this configurable/changeable for devs to set to local urls and for us to set as we package the apps for testing and production

@jonatwabash
Copy link
Contributor

Two points of clarification:

  1. Is the file with the bad url AllReadyApp/www/app/services.js?
  2. Where is configuration currently supposed to go?

@MKSessions
Copy link

Completed.

BillWagner pushed a commit that referenced this issue Nov 2, 2015
BillWagner pushed a commit that referenced this issue Nov 7, 2015
mheggeseth pushed a commit to mheggeseth/allReady that referenced this issue Nov 7, 2015
MisterJames pushed a commit that referenced this issue Nov 7, 2015
Update local fork from master
@jonatwabash
Copy link
Contributor

What was the final solution for making the domain url configurable? Does it simply have to be updated by hand in the services.js file, or is there some automated process that will change what currently looks like a hard-coded string while building and deploying the app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants