-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panda vis implementation #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Zbysekz 💯 This looks great!
A few questions abut potential improvement. And I'm off to play with this and optimization ⏯️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so i added setup.py into HTMpanda repo, that installs the PandaComm package that the server (user custom scripts) will use. The readme in panda repo is also updated. I think this is the best solution for now. No need to use pip (test.pypi) since the client app is run directly as python code and this i want to keep for now. Becouse of that, user need to git clone repo anyways, so running setup.py for installing pandaComm package is not additional big effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Zbysekz !! 👍
This is really great showcase example. Looks clean & lean, nice to use.
No need to use pip (test.pypi) since the client app is run directly as python code and this i want to keep for now.
yes, that is reasonable.
Ready to be merged, bumping reference: htm-community/htm.core#792 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect now!
Great work, thank you.
Now we can finally properly evaluate the detector in-depth 👀
…ementation" This reverts commit e34e6f4.
HTM core detector py file copied and prepared for use with pandaVis
Disussed here