Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panda vis implementation #33

Merged
merged 9 commits into from
Apr 30, 2020

Conversation

Zbysekz
Copy link

@Zbysekz Zbysekz commented Apr 23, 2020

HTM core detector py file copied and prepared for use with pandaVis
Disussed here

Copy link
Member

@breznak breznak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Zbysekz 💯 This looks great!

A few questions abut potential improvement. And I'm off to play with this and optimization ⏯️

nab/detectors/htmcore/htmcore_detector_pandaVis.py Outdated Show resolved Hide resolved
nab/detectors/htmcore/htmcore_detector_pandaVis.py Outdated Show resolved Hide resolved
nab/detectors/htmcore/pandaComm/pandaServer.py Outdated Show resolved Hide resolved
nab/detectors/htmcore/pandaComm/dataExchange.py Outdated Show resolved Hide resolved
Copy link
Author

@Zbysekz Zbysekz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we call the tm.compute and then get tm.getActiveCells() and tm.getPredictiveCells() for pandaVis?

No we can't, because we can only call getPredictiveCells() in between activateDendrites() and activateCells() link otherwise segments are not valid
Also this was the reason for PR739

nab/detectors/htmcore/htmcore_detector_pandaVis.py Outdated Show resolved Hide resolved
@Zbysekz
Copy link
Author

Zbysekz commented Apr 30, 2020

Ok so i added setup.py into HTMpanda repo, that installs the PandaComm package that the server (user custom scripts) will use. The readme in panda repo is also updated. I think this is the best solution for now. No need to use pip (test.pypi) since the client app is run directly as python code and this i want to keep for now. Becouse of that, user need to git clone repo anyways, so running setup.py for installing pandaComm package is not additional big effort.

breznak
breznak previously approved these changes Apr 30, 2020
Copy link
Member

@breznak breznak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Zbysekz !! 👍
This is really great showcase example. Looks clean & lean, nice to use.

No need to use pip (test.pypi) since the client app is run directly as python code and this i want to keep for now.

yes, that is reasonable.

nab/detectors/htmcore/htmcore_detector.py Show resolved Hide resolved
nab/detectors/htmcore/htmcore_detector.py Outdated Show resolved Hide resolved
nab/detectors/htmcore/htmcore_detector.py Outdated Show resolved Hide resolved
@Zbysekz
Copy link
Author

Zbysekz commented Apr 30, 2020

Ready to be merged, bumping reference: htm-community/htm.core#792

Copy link
Member

@breznak breznak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect now!
Great work, thank you.
Now we can finally properly evaluate the detector in-depth 👀

@breznak breznak merged commit e34e6f4 into htm-community:master Apr 30, 2020
Zbysekz pushed a commit to Zbysekz/NAB that referenced this pull request Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants