Cereal for TestNode #419
Merged
Cereal for TestNode #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finally ready for review when one of you get a chance. |
This was referenced Apr 20, 2019
Merged
Closed
Merged
ctrl-z-9000-times
approved these changes
Apr 20, 2019
breznak
reviewed
Apr 23, 2019
| @@ -114,7 +114,7 @@ class Dimensions : public std::vector<UInt>, public Serializable { | |||
| if (humanReadable && isInvalid()) ss << "(Invalid) "; | |||
| return ss.str(); | |||
| } | |||
|
|
|||
| /**** | |||
| CerealAdapter; | |||
| @@ -154,29 +154,21 @@ TEST_F(DimensionsTest, Overloads) { | |||
|
|
|||
| } | |||
|
|
|||
| // Dimensions object is treated as a vector<UInt32> by Cereal | |||
| // so it is serializable without the save/load functions. | |||
| /** | |||
| @@ -469,6 +502,12 @@ class Region : public Serializable { | |||
| // common method used by both constructors | |||
| // Can be called after nodespec_ has been set. | |||
| void createInputsAndOutputs_(); | |||
| void saveDims(std::map<std::string,Dimensions>& outDims, | |||
There was a problem hiding this comment.
nit, should have used saveDims_, but that's ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Cereal to the TestNode Region Implementation as the first plugin class.
However, a plugin cannot be tested without its corresponding Region class which wraps it so this includes the Region class as well. Instantiating a plugin using Cereal deserialization required some changes to the plugin interface, and corresponding changes to all plugins. As a consequence there are a lot of files changed but must of it are stubs and parallel routines for passing the Archive rather than a stream object.
Trying to keep from breaking the original save/load serialization was a challenge.