New method Connections::destroyMinPermanenceSynapses #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous this was a private function of the Temporal Memory. This is useful and general purpose. It is now a public method of Connections.
breznak
requested changes
May 5, 2019
ctrl-z-9000-times
added
ready
TM
code
breznak
approved these changes
May 12, 2019
| const Permanence A_perm = dataForSynapse(A).permanence; | ||
| const Permanence B_perm = dataForSynapse(B).permanence; | ||
| if( A_perm == B_perm ) { | ||
| return A < B; |
There was a problem hiding this comment.
I see you're already using the determinitstic sort logic from #465 👍
| * @param nDestroy - Must be greater than or equal to zero! | ||
| * @param excludeCells - Presynaptic cells which will NOT have any synapses destroyed. | ||
| */ | ||
| void destroyMinPermanenceSynapses(const Segment segment, Int nDestroy, |
There was a problem hiding this comment.
this method should now have its unit-test, given its now public in Connections.
There was a problem hiding this comment.
..probably the test could be copied from TM tests, if there were one
There was a problem hiding this comment.
The TM has unit tests which call this method, albeit indirectly via a method in the TM. I think that the testing coverage is good enough so I'm going to go ahead and merge this.
Thanks for reviewing this!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in PR #285.
Previous this was a private function of the Temporal Memory.
This is useful and general purpose.
It is now a public method of Connections.
TODO: