Added sqlite3 as third party package #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breznak
reviewed
Jul 1, 2020
|
|
||
| # SQLite does not provide a CMakeList.txt to buld with so we provide the following lines to perform the compile here. | ||
| # Since we are building here and not in the source folder, the library will show up directly under build/ThirdParty. | ||
| set(SRCS ${sqlite3_SOURCE_DIR}/sqlite3.c ${sqlite3_SOURCE_DIR}/sqlite3.h) |
There was a problem hiding this comment.
you might need to explicitely tell CMake this is a C (not C++) file somewhere here
https://github.com/htm-community/htm.core/pull/857/checks?check_run_id=827912596#step:6:173
breznak
approved these changes
Jul 2, 2020
| @@ -39,7 +39,7 @@ | |||
| # Note: on MSVC, run startupMSVC.bat after deleting the build folder. | |||
|
|
|||
| cmake_minimum_required(VERSION 3.7) | |||
| project(htm_core CXX) | |||
| project(htm_core CXX C) | |||
There was a problem hiding this comment.
I guess it doesn't hurt if we add C to the languages (?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sqlite3 package is now folded into the externs. It will be downloaded and compiled into a library for both release and debug. The .h is included in the include directories ${EXTERNAL_INCLUDES} and can be referenced as 'sqlite/sqlite.h'. The library is included in 'externlibs' and is merged into the core library. So, if you link with the htm.core library then it should be found.
Oh, you should not list sqlite.c or seqlite.h in src/CMakeLists.txt.
There are no unit tests included with this PR. I expect that the PlotRegion project will include enough testing to tell if it can link properly.