Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing items will throw an error #24

Closed
srowhani opened this issue Mar 29, 2017 · 1 comment · Fixed by #40
Closed

Removing items will throw an error #24

srowhani opened this issue Mar 29, 2017 · 1 comment · Fixed by #40

Comments

@srowhani
Copy link
Contributor

Removing items will throw an index out of bounds assertion error.

Threw together a branch illustrating this effect

https://github.com/srowhani/vertical-collection/tree/bug/remove-items

  removeItems() {
      const items = this.get('model.numbers');
      items.splice(0, this.get('numItemsToRemove'));
      this.set('model.numbers', items.slice());
    },
@pzuraq
Copy link
Contributor

pzuraq commented Apr 4, 2017

Will be able to work on this first thing next week, I have some ideas for how it can be addressed. It's related to #26, I had removed a lot of the VC removal logic to deal with issues with Glimmer but now I think we need to add it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants