-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 8 roadmap (tracking issue) #228
Comments
Wow, that's a lot of changes (and work involved), great job! :) I will do some tests on my codebase shortly and report my findings here. |
This is working great for me. I'm using it on MJML to remove the mobile navigation icons (hidden with CSS, but present in the HTML) with the following: selectors: [{ selector: 'div.mj-menu-trigger', format: 'skip' }], Much cleaner than the regex I was using before. Thanks for all your hard work making this happen! |
@Niek Got anything to report? |
Sorry for the delay @KillyMXI! I tested and can confirm it works great! I'm testing with a bunch of (fairly advanced) selector like |
Awesome. Thanks everyone. |
@webstech would you mind upgrading the type definitions over at https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/html-to-text to v8? <3 |
By the way, there is another issue related to type definitions: #223 |
Working on it. Wishing I had documented the process better - it was a mix of generated and hand-crafted code. The typescript code generator is having issues. Probably something on my end. |
PR 53812 has been opened. There is a commit for the v7 changes and another for v8. Deprecated code is still supported so there should be no breaking changes. Thanks for bringing this to my attention. fyi, I have updated my notifications for this repo to all activity so I won't miss issues. |
All in all, this was quite a quiet release. Time to close this issue. (That doesn't mean I stop listening for feedback though.) |
Thanks for your dedicated work! |
Do you have a link for this? My searches did not go well. Thanks. |
https://twitter.com/JavaScriptDaily/status/1402980878230376449?s=20 |
Goals
compile
andconvert
functions (an attempt to gain back some performance in batch processing jobs).Related issues and PRs
Checklist
html-to-text
;Looking for feedback
(I'm no longer highlighting this issue. But if you wish I'm still happy to hear any feedback - in comments here or as a separate issue.)
Performance
In case you can benchmark the batch processing time on a large enough practical dataset, I am curious how it differs between 7.1.1 and 8.0.0.
Anything unclear
Let me know if you find any changes in configuration and documentation confusing (weird configuration format, weird defaults, unclear instructions, whatever).
Web bundlers experience
Works out of the box / needs a workaround, configuration tweaking / etc; with what framework/bundler version...
It would be helpful to map out this area before I dig into it myself and can provide the support outside of Node environment.
The text was updated successfully, but these errors were encountered: