feat(htmlhint): add script-disabled rule (#301)

htmlhint · Sep 4, 2018 · bfb7a75 · bfb7a75
1 parent e01cd44
commit bfb7a75
Show file tree

Hide file tree

Showing 4 changed files with 56 additions and 37 deletions.
diff --git a/lib/htmlhint.js b/lib/htmlhint.js
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/rules/script-disabled.js b/src/rules/script-disabled.js
@@ -0,0 +1,21 @@
+HTMLHint.addRule({
+  id: 'script-disabled',
+  description: 'The <script> tag cannot be used.',
+  init: function(parser, reporter) {
+    'use strict';
+
+    var self = this;
+
+    parser.addListener('tagstart', function(event) {
+      if (event.tagName.toLowerCase() === 'script') {
+        reporter.error(
+          'The <script> tag cannot be used.',
+          event.line,
+          event.col,
+          self,
+          event.raw
+        );
+      }
+    });
+  }
+});
diff --git a/test/rules/script-disabled.spec.js b/test/rules/script-disabled.spec.js
@@ -0,0 +1,25 @@
+var expect = require('expect.js'),
+  HTMLHint = require('../../index').HTMLHint;
+var ruldId = 'script-disabled',
+  ruleOptions = {};
+ruleOptions[ruldId] = true;
+describe('Rules: ' + ruldId, function() {
+  it('Add external script file should result in an error', function() {
+    var code = '<body><script src="test.js"></script></body>',
+      messages = HTMLHint.verify(code, ruleOptions);
+    expect(messages.length).to.be(1);
+    expect(messages[0].rule.id).to.be(ruldId);
+    expect(messages[0].line).to.be(1);
+    expect(messages[0].col).to.be(7);
+    expect(messages[0].type).to.be('error');
+  });
+  it('Add inline script should result in an error', function() {
+    var code = '<body><script>var test = "test";</script></body>',
+      messages = HTMLHint.verify(code, ruleOptions);
+    expect(messages.length).to.be(1);
+    expect(messages[0].rule.id).to.be(ruldId);
+    expect(messages[0].line).to.be(1);
+    expect(messages[0].col).to.be(7);
+    expect(messages[0].type).to.be('error');
+  });
+});