Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all license headers from code #274

Merged
merged 2 commits into from
Aug 27, 2018

Conversation

Shinigami92
Copy link
Contributor

Fixes: #271

  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Short description of what this resolves:

The license texts are redundant and do not add value to an MIT license
In addition, the main author and contributors can be found in the package.json and others in the README.md

Proposed changes:

  • remove all header license texts

@thedaviddias
Copy link
Member

thedaviddias commented Aug 27, 2018

Hi @Shinigami92, you should remove what is generating "headers" inside the grunt file too.

@codecov-io
Copy link

Codecov Report

Merging #274 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #274   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files            1      1           
  Lines            1      1           
======================================
  Hits             1      1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14fd3aa...45292e6. Read the comment docs.

@thedaviddias thedaviddias merged commit 087c778 into htmlhint:develop Aug 27, 2018
@Shinigami92 Shinigami92 deleted the remove-license-headers branch August 28, 2018 05:22
thedaviddias pushed a commit that referenced this pull request Sep 3, 2018
* remove all license headers from code

* remove generated header
thedaviddias pushed a commit that referenced this pull request Sep 3, 2018
* remove all license headers from code

* remove generated header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants