-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move rules into dedicated attribute #476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@thedaviddias Ready for review |
thedaviddias
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
8 tasks
Shinigami92
added a commit
that referenced
this pull request
Jul 8, 2020
* feat: move rules into dedicated attribute * test: update tests
Shinigami92
added a commit
that referenced
this pull request
Jul 10, 2020
* feat: move rules into dedicated attribute * test: update tests
Shinigami92
added a commit
that referenced
this pull request
Jul 10, 2020
* feat: move rules into dedicated attribute * test: update tests
thedaviddias
pushed a commit
that referenced
this pull request
Jul 10, 2020
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-07-10) ### Bug Fixes * remove duplicate changelog ([#474](#474)) ([4e17338](4e17338)) ### Continuous Integration * trigger major bump ([be0b2af](be0b2af)) ### Features * move rules into dedicated attribute ([#476](#476)) ([c9fb2c3](c9fb2c3)) * new configuration structure ([#445](#445)) ([0b007b3](0b007b3)) ### BREAKING CHANGES * Rules have a new structure
thedaviddias
pushed a commit
that referenced
this pull request
Jul 10, 2020
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-07-10) ### Bug Fixes * remove duplicate changelog ([#474](#474)) ([4e17338](4e17338)) ### Continuous Integration * trigger major bump ([be0b2af](be0b2af)) ### Features * move rules into dedicated attribute ([#476](#476)) ([c9fb2c3](c9fb2c3)) * new configuration structure ([#445](#445)) ([0b007b3](0b007b3)) ### BREAKING CHANGES * Rules have a new structure
Shinigami92
added a commit
that referenced
this pull request
Jul 10, 2020
* feat: move rules into dedicated attribute * test: update tests
thedaviddias
pushed a commit
that referenced
this pull request
Jun 14, 2021
* feat: move rules into dedicated attribute * test: update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
We want to support a new configuration structure that can handle more than just the rules
So we have to move the rules to a dedicated
rules
attributeProposed changes: