Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: user-guide rules updates #650

Merged
merged 3 commits into from
Jun 8, 2021
Merged

docs: user-guide rules updates #650

merged 3 commits into from
Jun 8, 2021

Conversation

bcdady
Copy link
Contributor

@bcdady bcdady commented Jun 2, 2021

Short description of what this resolves:
Updates a few docs with readability and examples

Proposed changes:
Markdown modifications to 'rules' docs

@bcdady bcdady requested a review from thedaviddias as a code owner June 2, 2021 04:33
@bcdady bcdady changed the title Rules docs updates docs: user-guide rules updates Jun 2, 2021
@thedaviddias
Copy link
Member

Thanks @bcdady for these fixes!

@thedaviddias thedaviddias merged commit a68bf8f into htmlhint:master Jun 8, 2021
@bcdady
Copy link
Contributor Author

bcdady commented Jun 10, 2021

Thanks @bcdady for these fixes!

You're very welcome @thedaviddias. Can you confirm the syntax in this example is correct?
I'm still having issues with this rule. Example output:

L84 |... <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><path d="M3 6h18v2H3V6m0 5h18v2H3v-2m0 5...
                                                          ^ The attribute name of [ viewBox ] must be in lowercase. (attr-lowercase)

Maybe I should open a separate issue?

@coliff
Copy link
Member

coliff commented Jun 10, 2021

@bcdady - that's a known issue... ideally camelCase SVG attributes would be whitelisted.

see: #542

@thedaviddias
Copy link
Member

🎉 This PR is included in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants