Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add [[bin]] name to Cargo.toml to output prefixed executables #8

Closed
colemickens opened this issue Jan 11, 2021 · 3 comments
Closed

Comments

@colemickens
Copy link
Contributor

In the course of packaging this, I noticed that the built binaries are called client, server, and certificate-gen.

For my Nix derivation, I simply prefix them all with rkvm- but I'm wondering if it would be more appropriate to just fix this in the various binaries' Cargo.toml files so that they're automatically named with a prefix.

What do you think?

@colemickens
Copy link
Contributor Author

colemickens commented Jan 12, 2021

I forgot, the other reason this would be nice, I could add the same GitHub action that I added for another Rust project and you'd get Windows binaries attached to a GHA job for each commit. That way you can get more Windows users without them having to build it.

(versus, a zip of "client.exe, server.exe, certificate-gen.exe" might be a bit weird)

@BrendanBall
Copy link

BrendanBall commented Jan 16, 2021

This is also the case for cargo install --path server. It ends up putting a binary called server on your path. So I also think it would be great to rename it. I'm not sure if @htrefil might be more responsive if you just open a PR and maybe they'll just merge it

@htrefil
Copy link
Owner

htrefil commented Apr 18, 2023

Fixed.

@htrefil htrefil closed this as completed Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants