Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.1.0 seems to be broken #12

Closed
michalbundyra opened this issue Jan 22, 2018 · 2 comments
Closed

1.1.0 seems to be broken #12

michalbundyra opened this issue Jan 22, 2018 · 2 comments

Comments

@michalbundyra
Copy link
Contributor

Please see these tests:
https://travis-ci.org/zendframework/zend-stratigility/jobs/332049603#L644

So the problem is only on the latest release. It's because the interface extends PSR-15 interface and method defined in the PSR-15 interface typehint against PST-15 interface, not as before interop interface. Basically 1.1.0 has a BC Break...
@shadowhand
Copy link
Contributor

Okay, so we need to untag 1.1 and make it 2.0?

shadowhand added a commit that referenced this issue Jan 23, 2018
@shadowhand
Fix BC break from upgrade to PSR-15
a2cf51e 
Refs #12
@shadowhand shadowhand mentioned this issue Jan 23, 2018
Closed
shadowhand added a commit to http-interop/http-server-middleware that referenced this issue Jan 23, 2018
@shadowhand
Fix BC break from upgrade to PSR-15
4df5a63 
Refs http-interop/http-server-handler#12
@shadowhand shadowhand mentioned this issue Jan 23, 2018
Closed
@michalbundyra
Copy link
Contributor Author

I've just noted that I've opened issue in the wrong repository. http-server-handler is fine, the problem is only with http-server-middleware 1.1.0.

shadowhand added a commit to http-interop/http-server-middleware that referenced this issue Jan 23, 2018
@shadowhand
Fix BC break from upgrade to PSR-15
5181414 
Refs http-interop/http-server-handler#12
This was referenced Jan 23, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shadowhand @michalbundyra