Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.1.0 seems to be broken #6

Closed
shadowhand opened this issue Jan 23, 2018 · 4 comments
Closed

1.1.0 seems to be broken #6

shadowhand opened this issue Jan 23, 2018 · 4 comments
Assignees
@shadowhand
Labels
bug

Comments

@shadowhand
Copy link
Contributor

Please see these tests:
https://travis-ci.org/zendframework/zend-stratigility/jobs/332049603#L644

So the problem is only on the latest release. It's because the interface extends PSR-15 interface and method defined in the PSR-15 interface typehint against PST-15 interface, not as before interop interface. Basically 1.1.0 has a BC Break...

Refs http-interop/http-server-handler#12 by @webimpress
@shadowhand shadowhand self-assigned this Jan 23, 2018
@shadowhand shadowhand added the bug label Jan 23, 2018
@michalbundyra
Copy link

michalbundyra commented Jan 23, 2018 •
edited

PR #5 seems to be a good solution !

@shadowhand shadowhand mentioned this issue Jan 23, 2018
Closed
@shadowhand
Copy link
Contributor Author

PR #3 should be the correct fix.

@shadowhand
Copy link
Contributor Author

Fixed by #5.

@michalbundyra
Copy link

@shadowhand it can be closed now, we have 1.1.1 in place ! Thanks 👍

shadowhand added a commit that referenced this issue Jan 23, 2018
@shadowhand
Update README with warning about versions
ceef7d2 
Refs #6
Refs #5
@shadowhand shadowhand mentioned this issue Jan 23, 2018
Merged
@tuupola tuupola mentioned this issue Jan 23, 2018
Closed
shadowhand added a commit that referenced this issue Jan 23, 2018
@shadowhand
Update README with warning about versions (#7)
3f41f70 
Refs #6
Refs #5
@tuupola tuupola mentioned this issue Jan 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shadowhand shadowhand

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shadowhand @michalbundyra