Added support to websocket & parametrized changeOrigin configuration … #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed code style |
|
It looks like this PR is a combination of three changes, websocket proxy support, changeOrigin parameter and style changes. Would you please split these three into their own PRs so they can be reviewed on their own? |
|
Since this PR has too wide of a scope, I'm going to close. If you'd like to submit new PRs for the websocket proxy support and changeOrigin changes, I'd be glad to take a look! However we're unlikely to accept the style changes right now. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of http-proxy
Please ensure that your pull request fulfills these requirements:
masterbranchWhat is the purpose of this pull request? (bug fix, enhancement, new feature,...)
What changes did you make?
Provide some example code that this change will affect, if applicable:
Is there anything you'd like reviewers to focus on?
Please provide testing instructions, if applicable: