Add support for websockets when proxy is enabled #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe @thornjad can have a look at this? ;-) |
thornjad
requested changes
Aug 16, 2021
Comment on lines
-166
to
+171
| var proxy = httpProxy.createProxyServer({}); | ||
| var proxy = httpProxy.createProxyServer({ | ||
| target: options.proxy, | ||
| changeOrigin: true | ||
| }); | ||
| before.push(function (req, res) { | ||
| proxy.web(req, res, { | ||
| target: options.proxy, | ||
| changeOrigin: true | ||
| }, function (err, req, res, target) { | ||
| proxy.web(req, res, {}, function (err, req, res, target) { |
There was a problem hiding this comment.
What's different about creating the proxy with the options rather than using the options as before?
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure that your pull request fulfills these requirements:
masterbranchWhat is the purpose of this pull request? (bug fix, enhancement, new feature,...)
Fixes #142
What changes did you make?
Based on #528:
Provide some example code that this change will affect, if applicable:
Handles HTTP upgrades used for websockets by forwarding them in proxy mode.