Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no highestPort ts definition in latest version #119

Closed
Hishengs opened this issue Jul 16, 2021 · 2 comments
Closed

no highestPort ts definition in latest version #119

Hishengs opened this issue Jul 16, 2021 · 2 comments

Comments

@Hishengs
Copy link

hi, in the latest version: 1.0.28, there still no ts definition for highestPort

image

image

@eriktrom
Copy link
Member

add it and i'll merge.

in fact, if you do add it, consider adding something to the readme that says "contributions for ts defintions are actively merged, but due to the legacy requirements of this code base and the number of packages that depend on it, enhancements in the form of typings are the only thing that are likely to get merged, unless there is a new operating system error we need to handle" (which is really the only thing I check issues for these days - however type definitions are a great way to gain more activity and build a larger community around this lib now that u bring it up.

:)

@eriktrom
Copy link
Member

eriktrom commented Aug 2, 2022

closing - will reopen if code submitted

@eriktrom eriktrom closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants