* route priority

[spacekookie]

Currently serde_dir() seems to be broken. It works if it is the only route in an app, but fails to is never routed to when it's not.

pub(crate) fn setup(app: &mut Server<StateRef>, root: PathBuf) {
    app.at("/static").serve_dir(root.join("static")).unwrap();
}

This works, but the following does not:

pub(crate) fn setup(app: &mut Server<StateRef>, root: PathBuf) {
    app.at("/:owner/:repo").get(|_| async move { Ok("Hello world!") });
    app.at("/static").serve_dir(root.join("static")).unwrap();
}

[jbr]

I believe this is the same issue as #595 — if you add a distinct prefix to the dynamic route, like app.at("/api/:owner/:repo").get(|_| async { Ok("hello world") });, it will route correctly

[spacekookie]

That's not really doable for me though because I'm not building an api, I need the paths to be what users see because I'm rendering templates. The /static route needs to exist for the templates o pull in css files

[Fishrock123]

Does this work? That is, switching registration order?

pub(crate) fn setup(app: &mut Server<StateRef>, root: PathBuf) {
    app.at("/static").serve_dir(root.join("static")).unwrap();
    app.at("/:owner/:repo").get(|_| async move { Ok("Hello world!") });
}

at("/:param") should reasonably capture anything that is /v, /v/, but at("/:p/:p") should not match just /v or /v/ - if it does that's a bug, imo.

[jbr]

I've reproduced this problem and I'm not sure what the right solution is, but here's an update. Route prioritization exists in route-recognizer. (edit: I hadn't realized that this was under the http-rs umbrella when I wrote this comment, so it's possible we could change this behavior)

This issue can be reduced to the following failing test (using the test helpers in #601 for convenience):

#[async_std::test]
async fn static_routing() {
    let mut app = tide::Server::new();
    app.at("/:one/:two").get("two segments");
    app.at("/a/*").get("static + star");
    assert_eq!(app.get_body("/a/a").await, "static + star");
}

which results in

---- static_routing stdout ----
thread 'static_routing' panicked at 'assertion failed: `(left == right)`
  left: `"two segments"`,
 right: `"static + star"`', tests/wildcard.rs:127:5

Of note, route-recognizer is not order dependent, and instead uses a relative priority comparison that in this case is not what we want.

[jbr]

Update: This is fixed in route-recognizer master, so we just need them to publish a patch release

[jbr]

@spacekookie If you get a chance, could you confirm that this is fixed in tide master? Thanks!

[spacekookie]

The main branch doesn't work for me because i'm getting this error:

error: failed to select a version for `url`.
    ... required by package `serde_urlencoded v0.6.1`
    ... which is depended on by `http-types v2.2.1`
    ... which is depended on by `tide v0.11.0 (https://github.com/http-rs/tide#f8373ee1)`
    ... which is depended on by `octopus v0.1.0 (/home/projects/octopus)` versions that meet the requirements `= 2.1.0` are: 
2.1.0all possible versions conflict with previously selected packages.

  previously selected package `url v2.1.1`
    ... which is depended on by `http-types v2.2.1`
    ... which is depended on by `tide v0.11.0 (https://github.com/http-rs/tide#f8373ee1)`
    ... which is depended on by `octopus v0.1.0 (/home/projects/octopus)`

failed to select a version for `url` which could resolve this conflict

My Cargo.toml:

[package]
name = "octopus"
description = "A lightweight web frontend for git repositories"
version = "0.1.0"
authors = ["Katharina Fey <kookie@spacekookie.de>"]
edition = "2018"

[dependencies]
tide = { git = "https://github.com/http-rs/tide" }

[jbr]

does cargo update resolve that?